Closed thirteenowls closed 2 months ago
/ci try -t cross
Starting try run. Link to action
I forgot about the changelog entry, sorry!
/ci try -t cross
Starting try run. Link to action
The Windows CI failure seems to be caused by a recent commit to dtolnay/rust-toolchain
, which sets CARGO_HOME
: https://github.com/cross-rs/cross/actions/runs/8956947724/job/24605204754?pr=1483#step:4:21
Edit: Fixed in #1484.
/ci try -t cross
Starting try run. Link to action
oh yeah, it doesn't rebase to master, should fix that :3
/ci try -t cross
Starting try run. Link to action
failure is unrelated
Currently,
MountFinder
is used for almost all paths, rather than only for the host path in bind/volume mounts.Because of this,
docker build
invocations use the wrong working directory (/var/lib/docker/.../workdir-path
instead of/workdir-path
), causing failures for builds that usepre-build
with a relative file path, anddocker run
invocations use incorrect-v
arguments (e.g./var/lib/docker/.../toolchain-dir:/var/lib/docker/.../toolchain-dir
instead of/var/lib/docker/.../toolchain-dir:/toolchain-dir
).This PR fixes those issues by only using
find_path
andfind_mount_path
when necessary.