search

cross-rs / cross

“Zero setup” cross compilation and “cross testing” of Rust crates
Apache License 2.0
6.59k stars 365 forks source link

Use `/proc/self/mountinfo` as a fallback for `docker inspect` if using `HOSTNAME` fails #1485

Closed thirteenowls closed 4 months ago

thirteenowls commented 4 months ago

Fixes #1321.

Emilgardis commented 4 months ago

this is awesome! Isn't the description a bit misleading though? The fallback is actually docker now, not proc?

thirteenowls commented 4 months ago

Oh, you're right, it is ambiguous. Does "Use /proc/self/mountinfo as a fallback for docker inspect if using HOSTNAME fails" seem better to you? (just in case, proc is the fallback, it first tries to use the hostname as usual and only reads mountinfo if that doesn't work)

Emilgardis commented 4 months ago

I think that works!

thirteenowls commented 4 months ago

Done!

Emilgardis commented 4 months ago

Thank you!