Allow specifying only a tag or subtarget for images in config

cross-rs / cross

“Zero setup” cross compilation and “cross testing” of Rust crates

Apache License 2.0

6.21k stars 354 forks source link

Allow specifying only a tag or subtarget for images in config #1491

Closed thirteenowls closed 1 month ago

thirteenowls commented 1 month ago

Closes #1169.

Also supports specifying only a hash (@sha256:...) or subtarget (-centos).

Emilgardis commented 1 month ago

one thing I just thought about, would it be possible to also support a syntax like -centos, which would pick {default_image}:{default_tag}-centos?

thirteenowls commented 1 month ago

I've pushed the requested change, as well as subtarget support. :) Please let me know what you think, I'm not entirely confident about some bits.

Emilgardis commented 1 month ago

Can we merge this?

thirteenowls commented 1 month ago

I believe so! Thank you for taking the time to review my PRs. :)