search

cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
126 stars 67 forks source link

TemplateValueHydrator::ectract gets job object #197

Closed cbleek closed 8 years ago

cbleek commented 8 years ago

I've described how to add an additional elemet to job posting template in https://groups.google.com/d/msg/yawik/os6SC_SaOzw/GBdVBbBuAwAJ

I've noticed, that our TemplateValueHydrator::ectract method can gets a job object, which leads to an error. Checking the instance is a short fix, but the bug is probably somewhere else

https://github.com/cross-solution/YAWIK/blob/develop/module/Jobs/src/Jobs/Entity/Hydrator/TemplateValuesHydrator.php#L78

TiSiE commented 8 years ago

This currently only affects optional modules. We need to refactor the addition of custom template values, but will address this in a separate issue.