search

cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
125 stars 67 forks source link

Upgrade to doctrine/mongodb-odm to 1.1.x #312

Closed fedys closed 7 years ago

fedys commented 8 years ago

It would be great to upgrade Doctrine ODM to 1.1.x. Unfortunately, there are several BC breaks.

TiSiE commented 8 years ago

So ... tell us what exactly are these BC breaks in particular. :smile:

fedys commented 8 years ago
  1. I noticed problem with Core\Entity\ModificationDateAwareEntityTrait::setDateCreated(DateTime $dateCreated = null) ODM 1.1 passes Doctrine\ODM\MongoDB\Event\LifecycleEventArgs instance while ODM 1.0 passes nothing
  2. I overlooked ODM 1.1 requires PHP "^5.6 || ^7.0" thus upgrade is not possible for your evironment now :(
fedys commented 8 years ago

There may exist other BC breaks as well. I have not tested it thoroughly yet.

cbleek commented 8 years ago

I'll recheck, if we can upgrade.

cbleek commented 8 years ago

We can upgrade. All productive yawik instances we know are currently running php5.6 or can be upgraded.

When upgrading my local instance from php5.5 to php5.6 I'got the exception

2016-11-10 10:56:43 EXCEPTION mongo2:27017: exception: Index with name: permissions_view_1 already exists with different options in /home/cbleek/Projects/YAWIK/vendor/doctrine/mongodb/lib/Doctrine/MongoDB/Collection.php on line 312

I got my YAWIK running again by deleting all mongo indizes, However.

We can point out this issue in the Release notes.

So let's upgrade.

fedys commented 8 years ago

Great news! Do you want me to carry out the upgrade? I will go over the ODM 1.1 changelog and note the possible BC breaks. Then I will try to detect them in YAWIK (some of them are already detected) and fix them.

cbleek commented 8 years ago

Great news! Do you want me to carry out the upgrade?

Yes.

How do you rate the time? Can we'll make it in a couple of weeks, or will it be finished next year.

fedys commented 8 years ago

I assume there are minor BC breaks only. Estimated time is within a week. I will know more details after an initial research.