search

cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
125 stars 67 forks source link

fix Unittest in do-not-added-attributes-directly #348

Closed cbleek closed 7 years ago

cbleek commented 7 years ago

The commit https://github.com/cross-solution/YAWIK/commit/4d4ada8459f46bc4c775e6691bf581a625196bcf triggers an E_USER_DEPRECATED warning, if properties are accessed directly, In addition a couple views, controllers etc. are changed.

https://github.com/cross-solution/YAWIK/blob/b30b39326746d0b74f0f1e7f62453754adc2b699/module/Core/src/Core/Entity/AbstractEntity.php#L40

Tests are failing now. Please fix them

cbleek commented 7 years ago

@kilip I've marked the following tests to skip. But they should be fixed.

Can you do this?

cbleek@xenon:~/Projects/YAWIK$ grep -r YAWIK/issue module/*/test
module/Core/test/CoreTest/Entity/AbstactEntityTest.php:        $this->markTestSkipped('must be revisited. https://github.com/cross-solution/YAWIK/issues/348');
module/Core/test/CoreTest/Entity/AbstactEntityTest.php:        $this->markTestSkipped('must be revisited. https://github.com/cross-solution/YAWIK/issues/348');
module/Organizations/test/OrganizationsTest/Entity/OrganizationReferenceTest.php:        $this->markTestSkipped('must be revisited. https://github.com/cross-solution/YAWIK/issues/348 ');
cbleek commented 7 years ago

@kilip I've merged the branch into the develop. The Tests are still marked to skip and have to be fixed

cbleek commented 7 years ago

Perfekt. Thank you