search

cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
125 stars 67 forks source link

merge file_upload_optimization into develop #473

Closed cbleek closed 6 years ago

cbleek commented 6 years ago

modifications where done my @TiSiE

it's not already merged, because tests are missing. Please create tests and merge:

https://github.com/cross-solution/YAWIK/tree/file_upload_optimization

into develop..

kilip commented 6 years ago

I don't know what test is missing, but I have fixed failed Behat and PHPUnit tests.

Please let me know if I need to create a new tests for this issue.

cbleek commented 6 years ago

the file_upload_optimization branch adds a couple of classes.

eg.

https://github.com/cross-solution/YAWIK/blob/file_upload_optimization/module/Core/src/Core/Filter/File/Resize.php

@TiSiE can you add more infos?

TiSiE commented 6 years ago

These files are created/modified:

module/Core/config/module.config.php
module/Core/src/Core/Acl/FileAccessAssertion.php
module/Core/src/Core/Filter/File/Entity.php
module/Core/src/Core/Filter/File/EntityFactory.php
module/Core/src/Core/Filter/File/Resize.php
module/Core/src/Core/Filter/File/ResizeFactory.php
module/Core/src/Core/Form/View/Helper/FormEditor.php
module/Core/src/Core/Repository/RepositoryService.php
module/Core/src/Core/Repository/SnapshotRepository.php
module/Jobs/src/Jobs/Controller/ManageController.php
module/Jobs/src/Jobs/Filter/ViewModelTemplateFilterAbstract.php
module/Jobs/view/form/preview.phtml
module/Jobs/view/jobs/manage/form.phtml
module/Organizations/config/module.config.php
module/Organizations/src/Organizations/Controller/ProfileController.php
module/Organizations/view/organizations/profile/disabled.phtml

Tests should be especially checked/modified/created for these files:

cbleek commented 6 years ago

Hi @kilip do I have to create a pull request, or do you will create one?

cbleek commented 6 years ago

Hi @TiSiE

I've created a merge request.

tests are existing for.

Tests are missing for an older class. It's a huge class which propably should be refactored.

@TiSiE what do you think?

TiSiE commented 6 years ago

It's alright.There were no test present, and - as you already guessed correctly - the class will be refactored.