cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
125 stars 67 forks source link

zf2htmlpurifier missing in Jobs/composer.json #526

Closed cbleek closed 4 years ago

cbleek commented 5 years ago

mikemix/zf2htmlpurifier is missing as a dependency in module/Jobs/composer.json (I guess)

[Thu Nov 29 08:53:38 2018] 127.0.0.1:34308 [500]: /de/jobs/editTemplate/5bff9b008dc1b333168b456e - Class 'zf2htmlpurifier\Filter\HTMLPurifierFilter' not found in /home/cbleek/test/standard/module/Core/src/Filter/XssFilterFactory.php on line 34

kilip commented 5 years ago

Forgive me, I have remove this package because I think it is not used. You can fix this by adding mikemix/zf2htmlpurifier| in path/to/yawik/composer.json and module/Core/composer.json

This library is abandoned, we should replace this package in 0.33-dev.

https://packagist.org/packages/mikemix/zf2htmlpurifier

cbleek commented 5 years ago

@kilip

we need to fix this.

Can you take you the time to check, if https://packagist.org/packages/milqmedia/htmlpurifier is an option for a replacement?

kilip commented 5 years ago

@cbleek

Yes, I will check it.

kilip commented 5 years ago

@cbleek

Looks like milqmedia/htmlpurifier is not maintained too (last update on 2016). But I have found that integrating ezyang/htmlpurifier (used by zf2htmlpurifier) into yawik is not very difficult.

So I just copy and modify a code from zf2htmlpurifier into yawik.

kilip commented 5 years ago

@TiSiE I have forget to add ezyang/htmlpurifier into yawik/core composer config in #547 pull. The config should be like this:

/path/to/yawik/src/Core/composer.json file:
{
  "require": {
    "ezyang/htmlpurifier": "^4.10",
  }
}

If you want I can make a pull request for this small fix too.

cbleek commented 4 years ago

@kilip If you can create a release, please add the small change and release it.