search

cross-solution / YAWIK

YAWIK is a web application. It can be used as an ATS applicant tracking system or as a jobboard.
https://yawik.org
MIT License
125 stars 67 forks source link

Make YawikDemoSkin working again #615

Closed cbleek closed 3 years ago

cbleek commented 3 years ago

If you composer require yawik/demo-skin, add 'YawikDemoSkin' to your config/modules.php and run ./vendor/bin/phpunit, you'll notice some Test get broken.

Maybe because of the depricated https://gitlab.com/yawik/modules/DemoSkin

the errors

1) AuthTest\Controller\ManageControllerTest::testAccessWhenLoggedIn
Undefined index: REQUEST_URI

/home/cbleek/yawik/vendor/yawik/demo-skin/view/layout.phtml:48
/home/cbleek/yawik/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php:505
/home/cbleek/yawik/vendor/laminas/laminas-view/src/View.php:206
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:104
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:122
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:366
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:347
/home/cbleek/yawik/vendor/laminas/laminas-test/src/PHPUnit/Controller/AbstractControllerTestCase.php:319
/home/cbleek/yawik/module/Auth/test/AuthTest/Controller/ManageControllerTest.php:56

2) AuthTest\Controller\PasswordControllerFunctionalTest::testAccessWhenYouAreLogged
Undefined index: REQUEST_URI

/home/cbleek/yawik/vendor/yawik/demo-skin/view/layout.phtml:48
/home/cbleek/yawik/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php:505
/home/cbleek/yawik/vendor/laminas/laminas-view/src/View.php:206
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:104
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:122
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:366
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:347
/home/cbleek/yawik/vendor/laminas/laminas-test/src/PHPUnit/Controller/AbstractControllerTestCase.php:319
/home/cbleek/yawik/module/Auth/test/AuthTest/Controller/PasswordControllerFunctionalTest.php:79

3) AuthTest\Controller\PasswordControllerFunctionalTest::testAccessWhenYouAreNotLoggedIn
Undefined index: REQUEST_URI

/home/cbleek/yawik/vendor/yawik/demo-skin/view/layout.phtml:48
/home/cbleek/yawik/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php:505
/home/cbleek/yawik/vendor/laminas/laminas-view/src/View.php:206
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:104
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/View/Http/DefaultRenderingStrategy.php:122
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:331
/home/cbleek/yawik/vendor/laminas/laminas-eventmanager/src/EventManager.php:180
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:366
/home/cbleek/yawik/vendor/laminas/laminas-mvc/src/Application.php:325
/home/cbleek/yawik/vendor/laminas/laminas-test/src/PHPUnit/Controller/AbstractControllerTestCase.php:319
/home/cbleek/yawik/module/Auth/test/AuthTest/Controller/PasswordControllerFunctionalTest.php:89

The upstream of YawikDemoSkin has moved to https://gitlab.com/yawik/modules/DemoSkin

Commits to the master are deployed to https://yawik.org/demo. The repo is replicated to github.com/yawik/DemoSkin

kilip commented 3 years ago

@cbleek I am start working on this issue

kilip commented 3 years ago

@cbleek

this should be fixed in https://github.com/yawik/DemoSkin/commit/83be800c2a8fc2eed1d6c0c1b9403368db687047 commit