search

cross-solution / cross-solution.de

Homepage of CROSS Solution uses Strapi Backend cross-solution/cms
https://cross-solution.de
MIT License
2 stars 12 forks source link

cover page and yellow box changes #24

Closed Hetal2425 closed 4 years ago

Hetal2425 commented 4 years ago

cover page and yellow box changes.

cbleek commented 4 years ago

there is a conflict in CrossLayout.vue. Resolving is not a big issue.

but if you're using Cookies this way, it will only work in spa (Single Page App) mode. If you run the app in ssr (Server Side Renderung) mode by starting with "yarn dev:ssr" you'll get an error

Bildschirmfoto 2019-12-07 um 14 13 45

.

cbleek commented 4 years ago

@Hetal2425 can you merge our pull request and push your master please?

Hetal2425 commented 4 years ago

@cbleek : Yes Sure.

Hetal2425 commented 4 years ago

@cbleek : Merged code.

cbleek commented 4 years ago

Now please modify the code, so it runs in SSR mod too.

move the Notification from https://github.com/cross-solution/cross-solution.de/blob/master/src/layouts/CrossLayout.vue into the https://github.com/cross-solution/cross-solution.de/blob/master/src/boot/gdpr.js

Use LocalStorage instead of Cookies. Like I've done in the gdpr Notification.

The Issue with the splash page in SSR Mode may be solved using the nossr feature of quasar.

https://quasar.dev/vue-components/no-ssr#Usage

Just try it.

cbleek commented 4 years ago

and since "gdpr.js" not only contains gdpr.js related code, please rename it to "notifications.js"

Hetal2425 commented 4 years ago

@cbleek : But I can manage the cookies with respective code of SSR.

Like : this.$q.cookies.get('cookie_name').

Is it okay?

Hetal2425 commented 4 years ago

@cbleek : I have solved the issues with the cookie syntax of quasar.

Can I push the code?

cbleek commented 4 years ago

you can alway push. It's your repo. Ich you push to your master, the commit will appear in the PR.

Hetal2425 commented 4 years ago

@cbleek : Please check my last committed code.I have used the cookies,but you need to change with Local storage then I will do that.

Hetal2425 commented 4 years ago

@cbleek : There is the status of "Review requested" .May I need to do something for that or you review the code and merge?

Hetal2425 commented 4 years ago

@TiSiE : Thanks.

I will take care for next time in commit messages.

development0261 commented 4 years ago

Hi @cbleek & @TiSiE Good Morning Guys, I hope you are doing well.

Would you please let me know about new tasks?

Thanks.

cbleek commented 4 years ago

TiSiE hat created https://github.com/cross-solution/cross-solution.de/issues/26

development0261 commented 4 years ago

Great. Thanks. I will check it.