search

crossbario / autobahn-cpp

WAMP for C++ in Boost/Asio
https://crossbar.io/autobahn
Boost Software License 1.0
251 stars 104 forks source link

Fix VS2019 warning due to discarding nodiscard value #213

Closed robinlinden closed 3 years ago

robinlinden commented 3 years ago

Normally I'd just delete this since we explicitly copy it into the lambda anyway, but there are a lot of comments here about that this may be needed(?)

warning C4834: discarding return value of function with 'nodiscard' attribute

robinlinden commented 3 years ago

I'm working on setting up Windows CI and ran into a bunch more warnings. Hold off on this for a bit and I'll fix all of them at once.

oberstet commented 3 years ago

this is great! we should totally add nice CI badges to the README, plus branch protection. done the latter just now - need to see if that works as expected:

Bildschirmfoto von 2020-10-02 19-38-32

robinlinden commented 3 years ago

Ah, cool with the branch protection! I can go ahead and add some badges if you like. :D

oberstet commented 3 years ago

badges: oh yes, of course! I'm not sure how to add such a badge with status-based coloring .. eg in autobahn-python / travis, we have

https://github.com/crossbario/autobahn-python#autobahnpython

(once we figured out badges for GH actions, we need to add new GH actions badges in other repos then as well as we migrate to GH actions over time .. eg @om26er already added/migrated other stuff to GH actions https://github.com/crossbario/autobahn-js/actions?query=workflow%3A%22Autobahn+JS+CI%22)