Closed robinlinden closed 3 years ago
awesome! we now have some real CI covering multiple platforms=)
ok, added 2 badges to the https://github.com/crossbario/autobahn-cpp/blob/master/README.md
not sure what to do about "Conan CI", which shows up as a separate thing in https://github.com/crossbario/autobahn-cpp/actions, but there is no respective yml file in https://github.com/crossbario/autobahn-cpp/tree/master/.github/workflows - which is how to refer target workflow in badges ...
Cool! Looks good! :)
Hmm. Not sure why "Conan CI" is still there. That was in an older PR and I removed it before we merged that one.. Can you try deleting the only run in that workflow? There should be a delete button on this page https://github.com/crossbario/autobahn-cpp/actions/runs/285060260
^ ahhh! ok, deleted (only) that conan workflow ... looks "clean" now. thanks!
btw, fwiw, whilst looking for the delete button above, I found a "create status badge" menu item (I figured it out and added it manually, so haven't tried it .. but it sounds promising):
I added the Windows jobs in a separate workflow file as it differed too much from the Linux CI to make sense in there.
The new Boost_DEFINITIONS is because Boost has a weird autolink feature (probably something like
#pragma link boostlib.lib
behind a bunch of defines) that assumes that libraries are named in a specific way and that can be disabled by setting a define. Conan places this define in Boost_DEFINITIONS.