make methods on_ws_... protected on wamp_websocketpp_websocket_transport

crossbario / autobahn-cpp

WAMP for C++ in Boost/Asio

https://crossbar.io/autobahn

Boost Software License 1.0

251 stars 104 forks source link

make methods on_ws_... protected on wamp_websocketpp_websocket_transport #223

Closed pratman closed 3 years ago

pratman commented 3 years ago

To allow users to inherit from this class and:

handle reconnection through on_ws_fail and on_ws_close
catching the throw that happens on answering to goodbye message when process_goodbye does: m_session_id = 0; and calles send_message with default parameter session_established = true and then send_message checks for: if (session_established && !m_session_id) { throw no_session_error(); }

pratman commented 3 years ago

Should I split this issue? As the throw is self-produced and seems to be a bug. The request to make those methods protected instead of private is an enhancement to make the transport more versatile.

oberstet commented 3 years ago

the issue should describe the problem - not a proposed solution. and yes, if there are 2 problems, then there should be 2 issues. after that, we can discuss possible solutions. then we can select - if that involves changing public API, other users should have a change to state an opinion. then a PR is needed.

rgd inheritance: unlikely we support that. implementation inheritance for users is wrong most of the time. but that doesn't matter: what is the problem in the first place? then we can discuss possible solutions.

pratman commented 3 years ago

Creating 2 issues for 2 different topics