crossbario / autobahn-java

WebSocket & WAMP in Java for Android and Java 8
https://crossbar.io/autobahn
MIT License
1.52k stars 427 forks source link

Bump version and release v21.5.1 #521

Closed jellisgwn closed 2 years ago

jellisgwn commented 3 years ago

https://nvd.nist.gov/vuln/detail/CVE-2020-28491

om26er commented 3 years ago

I should be able to update the dependencies and put out a new autobahn-java release during this week

jellisgwn commented 3 years ago

hi @om26er, any progress on this?

om26er commented 3 years ago

@jellisgwn sorry for the delay. I have prepared a PR https://github.com/crossbario/autobahn-java/pull/523 which updates the version numbers alongside other changes. However to do a new release I need to fix https://github.com/crossbario/autobahn-java/issues/522 first. I will work on that during the weekend.

jellisgwn commented 3 years ago

@om26er nothing to apologize for :) thanks for the update

oberstet commented 3 years ago

@om26er is there anything else we should do/work on before a new release from your PoV?

om26er commented 3 years ago

@oberstet I need to make some changes in the build gradle so it only uploads to maven central. Should have a PR tomorrow.

So I guess that would be a better time to tag a new release

oberstet commented 3 years ago

merged via https://github.com/crossbario/autobahn-java/pull/525

oberstet commented 3 years ago

@om26er Q: is there anything more you want to do/merge before a new release? how do I do a maven release?

om26er commented 3 years ago

All the required changes have already landed. Please tag a new release.

The upload procedure to Sonatype is a bit complex as it seems currently only I have access to it (historic reasons). I am going to read a bit more into other ways of doing it, so that it can be collaborated. Will ask on the Sonatype forums

jellisgwn commented 3 years ago

@oberstet / @om26er will this still happen?

om26er commented 3 years ago

@oberstet Can you please tag a new release, then I should be able to upload and publish it. I will then also write the document about publishing to the new location.

oberstet commented 3 years ago

@om26er thanks! ok, I've tagged https://github.com/crossbario/autobahn-java/tree/v21.7.1 and test/build works fine https://gist.github.com/oberstet/9c02d71fa56ad8a8c52ad1fd04bb7df0

@jellisgwn sorry for the sluggish response:( I know. well. fwiw, I am working on a DAO for WAMP that may allow us to make all of this sustainable, aligning interests and resources in the WAMP community. stay tuned=)

jellisgwn commented 3 years ago

@oberstet thanks for the response.

If here are issues sustaining the project it would be good to get them out in the open and see if a community exists to help out.

om26er commented 2 years ago

@jellisgwn The new version is landed now. Sorry it took a while, going forwards I'll make sure to get the releases out quickly

jellisgwn commented 2 years ago

@om26er thanks!

Is there a reason it's not showing as the latest release? I see it's there and pushed to maven but it's not showing as the latest here on GitHub.

om26er commented 2 years ago

Seems like the new tag wasn't pushed. I don't have the permissions to do that, Tobias has.

oberstet commented 2 years ago

@om26er v21.7.1 is here https://github.com/crossbario/autobahn-java/tree/v21.7.1 - what else do you mean?

oberstet commented 2 years ago

does our CI set env var AUTOBAHN_BUILD_VERSION https://github.com/crossbario/autobahn-java/blob/d9a591ca2cbae15dff27a40b4075c48a251c60f3/autobahn/build.gradle#L16 ? from the tag?

om26er commented 2 years ago

I think @jellisgwn is only talking about the new release not showing on the homepage of the project. Screenshot_20210807_011749

So that's solely related to git tag and git push. Though I am not sure why it won't show there...

oberstet commented 2 years ago

aah, ok! not sure, but it seems it required manual release on github (at least this time), which worked:

Bildschirmfoto von 2021-08-06 22-25-49 Bildschirmfoto von 2021-08-06 22-26-01

om26er commented 2 years ago

Great, this look good now

jellisgwn commented 2 years ago

Looking good 👍

oberstet commented 2 years ago

@jellisgwn thanks for your patience=) and @om26er thx for you help!