search

crossbario / autobahn-python

WebSocket and WAMP in Python for Twisted and asyncio
https://crossbar.io/autobahn
MIT License
2.48k stars 767 forks source link

XBR: use upstream py-eth-sig-utils #1260

Open oberstet opened 5 years ago

oberstet commented 5 years ago

orignally, we had to use our fork https://github.com/crossbario/py-eth-sig-utils because of issues on pypy resulting from dependency on full ethereum.

upstream has merged our PR https://github.com/rmeissner/py-eth-sig-utils/pull/6 - means, we should:

  1. delete our fork
  2. depend on the next upstream release py-eth-sig-utils>=0.4.0

here: https://github.com/crossbario/autobahn-python/blob/897c349952ead7f69f6e720183a2b4c17987a64b/setup.py#L156

oberstet commented 4 years ago

CI deploy step is failing because of that too: https://travis-ci.org/crossbario/autobahn-python/jobs/608105606

rndwb commented 4 years ago
  1. depend on the next upstream release py-eth-sig-utils>=0.4.0

As it is done already? https://github.com/crossbario/autobahn-python/blob/master/setup.py#L157 Too bad that version is not released yet and this leads to

$ cat requirements.txt
autobahn[serialization,xbr]
$ pip install -r requirments.txt
...
  ERROR: Could not find a version that satisfies the requirement py-eth-sig-utils>=0.4.0; extra == "xbr" (from autobahn[serialization,xbr]->-r requirements.txt (line 1)) (from versions: 0.1.0, 0.2.0, 0.3.0)
ERROR: No matching distribution found for py-eth-sig-utils>=0.4.0; extra == "xbr" (from autobahn[serialization,xbr]->-r requirements.txt (line 1))
oberstet commented 4 years ago

upstream isn't released yet, right. as a workaround, this should do the trick:

pip install https://github.com/rmeissner/py-eth-sig-utils/archive/master.zip#egg=py-eth-sig-utils