search

crossbario / autobahn-python

WebSocket and WAMP in Python for Twisted and asyncio
https://crossbar.io/autobahn
MIT License
2.47k stars 763 forks source link

Full details about WebSocket connections logged at level info #1588

Closed PhilippWendler closed 1 year ago

PhilippWendler commented 1 year ago

This issue is similar to #1561, but about a different instance.

Since a196a8ba069291f390bac19644b0a7a7a38b7e63 there exists the following code: https://github.com/crossbario/autobahn-python/blob/9f425ff5792348c2f6dc3e7c3297c82f7fb5e793/autobahn/websocket/protocol.py#L2564

This means that for every WebSocket connection the full details including all headers are logged at level INFO. I would say that this is even dangerous because it includes session cookies, but at least it is disturbing. Could this please be removed or at least switched to level DEBUG like it was done in other logging statements in ccf450332bb43cab02e0f2c5699cd686130e5f41?

PhilippWendler commented 1 year ago

Thanks a lot for the quick fix and the release! Works nicely.