search

crossbario / autobahn-testsuite

Autobahn WebSocket protocol testsuite
https://crossbar.io/autobahn/
Apache License 2.0
1k stars 84 forks source link

Spelling #40

Closed jsoref closed 9 years ago

jsoref commented 9 years ago

Please feel free to fold these changes together (or to drop individual changes, etc.)

oberstet commented 9 years ago

Awesome! Are you using a grammer aware, code refactoring spell checker? Changing wasHandshaked (guess that is wrong grammatically or not a proper word) to didHandshake ... ;)

jsoref commented 9 years ago

@oberstet: no, I use a very dumb set of scripts to identify "words", and then feed the word list to a random spell checker. Recently, that's the OS X system spell checker w/in TextEdit.app.

It complained that "Handshaked" wasn't a word.

When I go to fix words, I look at the context because there's often an a question as to what word someone wanted (typically a choice of two similarly spelled words), so I think through them. I actually went through two iterations for that here. iirc I first picked gotHandshake, but before making the PR, I decided that I didn't like "got" :).

A cool thing about the OS X spell checker is that for a while it decided that the codebase was German because of The Project Gutenberg EBook of Faust: Der Tragödie erster Teil file.

When I'm awake, I delete files that pollute the corpus before I run my scripts, and I've since improved my scripts to have a slightly larger list of things to ignore (for Faust, I ended up deleting the file and rerunning the script which resulted in a slightly easier to manage corpus).

oberstet commented 9 years ago

@jsoref Faust, hehe, I see. Never mind, I guess not only spell checkers get challenged by that;)