Fix opcode in Case 3.6.

crossbario / autobahn-testsuite

Autobahn WebSocket protocol testsuite

https://crossbar.io/autobahn/

Apache License 2.0

973 stars 82 forks source link

Fix opcode in Case 3.6. #97

Open andrey-zelenkov opened 5 years ago

andrey-zelenkov commented 5 years ago

Case Description:

Send Ping with RSV = 6.

But opcode used in Case 3.6 in sendFrame() function is 2 (that corresponds to the binary message):

https://github.com/crossbario/autobahn-testsuite/blob/058db3a36b7c3a1edf68c282307c6b899ca4857f/autobahntestsuite/autobahntestsuite/case/case3_6.py#L31

Please use opcode = 9 for Ping (or change case description).

aerique commented 5 years ago

Came here to submit this issue. Was expecting it to be a problem on my end :smiley:

Output from my tests:

[…]
#S(FRAME :FIN T :RSV1 T :RSV2 T :RSV3 NIL :OPCODE 2 :OPCODE-TYPE :BINARY :MASK NIL :PAYLOAD-LENGTH 13 :MASKING-KEY 0 :PAYLOAD-DATA (72 101 108 108 111 44 32 119 111 114 108 100 33))
CASE-3-6: (FRAME-OPCODE FRAME) failed: 
Expected 9 but saw 2
CASE-3-6: (FRAME-OPCODE-TYPE FRAME) failed: 
Expected :PING but saw :BINARY
CASE-3-6: 3 assertions passed, 2 failed.
[…]