search

crossbario / cfxdb

Database schemata for CrossbarFX and XBR, based on zLMDB
MIT License
0 stars 6 forks source link

add UserKeys table to xbrmm #45

Closed om26er closed 4 years ago

oberstet commented 4 years ago

last comment: I guess you have ensured to use new UUIDs for all tables (and indexes)?

otherwise: +1, looks good!

om26er commented 4 years ago

last comment: I guess you have ensured to use new UUIDs for all tables (and indexes)?

Yes, otherwise CrossbarFX would eve start if there was a UUID conflict.

om26er commented 4 years ago

so xbrmm.fbs change (which is fine!), and hence xbrmm.bfbs changes (right). but xbr.bfbs?

I just tried on master as well, it seems to recreate xbr.bfbs. Maybe its a leftover from a previous PR or something ? fbs2

oberstet commented 4 years ago

Yes, otherwise CrossbarFX would eve start if there was a UUID conflict.

yeah, so the built-in protection inside zlmdb worked (wasn't sure) :)

I just tried on master as well, it seems to recreate xbr.bfbs. Maybe its a leftover from a previous PR or something ?

ok, fine! maybe also a subtle (insignificant) flatc change. guess it'll be fine and I should stop worrying;)