search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Allow configuation of RawSocket transport max message size accepted #1207

Open fhriley opened 6 years ago

fhriley commented 6 years ago

The twisted version of raw sockets sets the max length in the handshake reply to 16777216, but the router won't actually let you send any message larger than 131072.

oberstet commented 6 years ago

Yep, because the maximum message size being accepted by Crossbar.io currently isn't configurable: https://github.com/crossbario/crossbar/blob/master/crossbar/router/protocol.py#L581

So we need to make it configurable;)

fhriley commented 6 years ago

Allowing configuration of the length doesn't fix the bug I'm reporting. The bug is that during handshake, the router's handshake reply always says the maximum length is 16777216. If the max message size is 131072, as it is currently set to, the router's handshake reply should say the maximum length is 131072. As is, the implementation is not implementing the spec correctly.

oberstet commented 6 years ago

Yes, right. Fixing the issue here will involve fixing this issue https://github.com/crossbario/autobahn-python/issues/922, resulting in spec conformance.