search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

wamp.session.on_leave doesn't provide all three positional arguments #1691

Open mrrishimeena opened 4 years ago

mrrishimeena commented 4 years ago

As per the documentation in wamp-proto [link: https://wamp-proto.org/_static/gen/wamp_latest.html]

wamp.session.on_leave should provide three positional arguments:

  1. session|id - The session ID of the session that left
  2. authid|string` - The authentication ID of the session that left
  3. authrole|string - The authentication role of the session that left

But crossbar doesn't provide authid & authrole.

oberstet commented 4 years ago

yes, the addition of authid and authrole was a recent" change in the WAMP spec (here) that hasn't made it into crossbar yet.

the fix is a one line change here:

https://github.com/crossbario/crossbar/blob/2a7ebfd6529645524eb1816efc595590bb58167e/crossbar/router/session.py#L959

mrrishimeena commented 4 years ago

When can we expect this change in crossbar docker image?

mrrishimeena commented 3 years ago

any update related to this issue?