search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 275 forks source link

Remove the zlmdb and numpy dependencies from crossbar #1823

Closed Emantor closed 3 years ago

Emantor commented 3 years ago

Remove numpy and zlmdb from the crossbar dependencies and remove the version checking code for them. zlmdb was used for the time_ns function, which is now imported from txaio since 2f26fef9de4ac87f39291593a777fdd5f88cc8ef.

codecov-io commented 3 years ago

Codecov Report

Merging #1823 into master will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   32.49%   32.53%   +0.03%     
==========================================
  Files          84       84              
  Lines       14527    14511      -16     
  Branches     2561     2561              
==========================================
  Hits         4721     4721              
+ Misses       9398     9382      -16     
  Partials      408      408
Impacted Files Coverage Δ
crossbar/node/main.py 9.41% <ø> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5aa0682...35ef751. Read the comment docs.

Emantor commented 3 years ago

Looks like the CI fails because of #1822.

oberstet commented 3 years ago

these dependencies should not be removed: we plan to expand both their use in the codebase