lmcgartland commented 3 years ago

This resolves #1618 by checking for the attribute 'io_counters' before trying to access it on Linux systems.

codecov-io commented 3 years ago

Codecov Report

Merging #1826 (b35ba6f) into master (20540f1) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
- Coverage   32.49%   32.49%   -0.01%     
==========================================
  Files          84       84              
  Lines       14527    14528       +1     
  Branches     2561     2562       +1     
==========================================
  Hits         4721     4721              
- Misses       9396     9399       +3     
+ Partials      410      408       -2

Impacted Files	Coverage Δ
crossbar/common/monitor.py	`17.00% <0.00%> (-0.12%)`	:arrow_down:
crossbar/bridge/mqtt/wamp.py	`30.44% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20540f1...b35ba6f. Read the comment docs.

oberstet commented 3 years ago

thanks for fixing this!

the CI fails are unrelated to this issue: seems like pypy/cryptography now wants a more recent openssl on the travis buildbox https://travis-ci.com/github/crossbario/crossbar/jobs/430892567#L461

.. we'll fix that in a different change

crossbario / crossbar

Check for io_counters feature #1826

Codecov Report