crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Fix `freeze` make target to patch pinned file #1886

Open om26er opened 3 years ago

om26er commented 3 years ago

The make target should update the pinned py-sid and py-multihash to the crossbario forked variants.

The make target should also bump the release version.

Based on this comment https://github.com/crossbario/crossbar/pull/1884#issuecomment-890177195

om26er commented 3 years ago

That would be a bit difficult to do in bash, so a python script like this that takes the output of git describe --abbrev=0 as input could work.

import datetime
import sys

TAG = "v21.3.1"

def print_next_version():
    split = TAG.split(".")
    if split[0].startswith("v"):
        split[0] = split[0][1:]

    now = datetime.datetime.now()
    year, month = now.year, now.month

    if year < int(split[0]) or month < int(split[1]):
        print("Invalid system date")
        sys.exit(1)

    if year > int(split[0]):
        version = f"{year}.{month}.1"
    elif month > int(split[1]):
        version = f"{year}.{month}.1"
    else:
        version = f"{year}.{month}.{int(split[2]) + 1}"

    print(version)

Then we can just do sed the new printed version to crossbar/_version.py

oberstet commented 3 years ago

yes, the problem is freezing of deps

https://github.com/crossbario/crossbar/blob/712d9da9173829be7df3ecba5dbb7981dd648fcd/Makefile#L74

that point to forked versions

https://github.com/crossbario/crossbar/blob/712d9da9173829be7df3ecba5dbb7981dd648fcd/requirements-min.txt#L17

using "pip3 freeze" / "hashin" ...