should urllib3 be removed from configuration files?

crossbario / crossbar

Crossbar.io - WAMP application router

https://crossbar.io/

Other

2.05k stars 274 forks source link

should urllib3 be removed from configuration files? #1901

Closed yuluc123 closed 2 years ago

yuluc123 commented 2 years ago

Hi I notice that urllib3 is listed as a dependency in configuration files such as requirements-latest.txt, but it is not used in source code. So is it necessary to remove urllib3 from dependencies?

oberstet commented 2 years ago

no, I guess it's an indirect dependency. note that we generate requirements-latest.txt to contain all direct and all indirect (recursively) deps