rlinks: duplicate events after resubscribe

crossbario / crossbar

Crossbar.io - WAMP application router

https://crossbar.io/

Other

2.05k stars 275 forks source link

rlinks: duplicate events after resubscribe #1920

Closed asimfarooq5 closed 2 years ago

asimfarooq5 commented 2 years ago

I've found a sub bug similar to #1916

instance A connected to instance B
Subscribe to a topic (let's call it com.test) on instance B
subscribe/unsubscribe to that topic multiple times
publish on topic com.test on instance A

Result: Instance B receives that single published event multiple times.

om26er commented 2 years ago

Thanks, this is reproducible. It actually results in N events (depending on the number of subscribe and unsubscribes)

oberstet commented 2 years ago

It actually results in N events (depending on the number of subscribe and unsubscribes)

the rlink should process the remote meta API event "on-sub-created" - not "on-sub-added", which is fired on every subscribe to an already existing subscription in the remote broker ..

this difference of meta events can be seen in the broker code here:

https://github.com/crossbario/crossbar/blob/4736e67b75bcd3f41be82e86008d9822299809ea/crossbar/router/broker.py#L862

om26er commented 2 years ago

@asimfarooq5 I can no longer reproduce this issue. Please try Crossbar from master and let me know if it's fixed for you as well.

asimfarooq5 commented 2 years ago

It seems to be fixed