search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 275 forks source link

Complete master node router cluster checking #1931

Open markope opened 2 years ago

markope commented 2 years ago

should this line not be if node and node.status != 'online':

https://github.com/crossbario/crossbar/blob/e8f546be14b3b2b8e96c3d185f3330022fbcc892/crossbar/master/cluster/routercluster.py#L104

oberstet commented 2 years ago

actually, I think this needs fixing (couple of lines below):

https://github.com/crossbario/crossbar/blob/e8f546be14b3b2b8e96c3d185f3330022fbcc892/crossbar/master/cluster/routercluster.py#L109

but yeah, currently, that if/then block is a noop (besides logging, and setting is_running_completely = False in both cases, it does nothing)

=> check all workers we expect for data planes associated with this router cluster are running