crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Remove upper version bounds in all dependencies #1937

Closed oberstet closed 2 years ago

oberstet commented 2 years ago

currently, the https://github.com/crossbario/crossbar/blob/master/requirements-min.txt contains a few dependencies with upper version bounds defined. these include:

can we remove those upper bounds? we should test:

oberstet commented 2 years ago

regarding twisted, things are still unchanged with the latest release (though there is a new one upcoming ..): pip install -U twisted[tls,http2]

(cpy39_4) (base) oberstet@intel-nuci7:~/scm/3rdparty/twisted$ pip show twisted
Name: Twisted
Version: 21.7.0
Summary: An asynchronous networking framework written in Python
Home-page: https://twistedmatrix.com/
Author: Twisted Matrix Laboratories
Author-email: twisted-python@twistedmatrix.com
License: MIT
Location: /home/oberstet/cpy39_4/lib/python3.9/site-packages
Requires: attrs, Automat, constantly, hyperlink, incremental, typing-extensions, zope.interface
Required-by: 
(cpy39_4) (base) oberstet@intel-nuci7:~/scm/3rdparty/twisted$ pip show h2
Name: h2
Version: 3.2.0
Summary: HTTP/2 State-Machine based protocol implementation
Home-page: https://github.com/python-hyper/hyper-h2
Author: Cory Benfield
Author-email: cory@lukasa.co.uk
License: MIT License
Location: /home/oberstet/cpy39_4/lib/python3.9/site-packages
Requires: hpack, hyperframe
Required-by: 
(cpy39_4) (base) oberstet@intel-nuci7:~/scm/3rdparty/twisted$ pip show hyperframe
Name: hyperframe
Version: 5.2.0
Summary: HTTP/2 framing layer for Python
Home-page: https://python-hyper.org/hyperframe/en/latest/
Author: Cory Benfield
Author-email: cory@lukasa.co.uk
License: MIT License
Location: /home/oberstet/cpy39_4/lib/python3.9/site-packages
Requires: 
Required-by: h2
(cpy39_4) (base) oberstet@intel-nuci7:~/scm/3rdparty/twisted$ 

it is still the same on twisted master: https://github.com/twisted/twisted/blob/2d6a7d6748309b3c199c073c94b84f7f864f8f76/setup.cfg#L91

so actually, in crossbar, we should still have:

h2>=3.2,<4.0
priority>=1.1,<2.0
hyperframe>=5.2,<6.0
oberstet commented 2 years ago

rgd idna, we can remove the upper bound!

idna>=2.4

and rgd urllib3 it should work (now that requests doesn't need a pinning anymore):

urllib3>=1.26.8

so in summary, we can adjust the requirements-min.txt and it should work (hopefully)

h2>=3.2,<4.0
priority>=1.1,<2.0
hyperframe>=5.2,<6.0
idna>=2.4
urllib3>=1.26.8
oberstet commented 2 years ago

see PR https://github.com/crossbario/crossbar/pull/1938

oberstet commented 2 years ago

fixed (as described above)