crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 275 forks source link

PyPI release of version 22.1.1? #1942

Closed Bastian-Krause closed 2 years ago

Bastian-Krause commented 2 years ago

Hi,

v22.1.1 is not released on PyPI. Is there a reason for that?

Thanks!

oberstet commented 2 years ago

Yeah, sorry, so the story is, we have open-sourced and integrated a large chunk of code (here). Including dependencies. While doing so, I did move to requirements-latest

https://github.com/crossbario/crossbar/commit/8e2f9d3303fa85a270944601f80a04ae4047be9e#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R30

and @om26er repaired some fallout from that rgd source installs

https://github.com/crossbario/crossbar/commit/712d9da9173829be7df3ecba5dbb7981dd648fcd#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R45

but unfortunately, now that a tried to push that to PyPI, turns out, that doesn't yet work

adding 'crossbar-22.1.1.dist-info/top_level.txt'
adding 'crossbar-22.1.1.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
twine upload dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading crossbar-22.1.1-py2.py3-none-any.whl
100%|██████████████████████████████████████████████████████████████████████████████████████████████████| 808k/808k [00:01<00:00, 528kB/s]
NOTE: Try --verbose to see response content.
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: 'autobahn[compress,encryption,scram,serialization,twisted,xbr] @ git+https://github.com/crossbario/autobahn-python.git@master#egg=autobahn[twisted,encryption,compress,serialization,scra
make: *** [Makefile:124: publish] Fehler 1

long story short: let me switch back to requirements-min and see if that works for me locally. give it a bit of testing.

however: since v22.1.1 was never released on PyPI, and if above change makes it work, I'd move also the tag on GitHub. Just for this 1 change to requirements-min.

Again, sorry, I knew the big chunk code merge would make some ripples .. we're almost through all though;) hopefully.

oberstet commented 2 years ago

PR is here https://github.com/crossbario/crossbar/pull/1943

Please also note the change of AGPL3 to SPDX-License-Identifier: EUPL-1.2 which we took the chance to change to (and are allowed to do so, since we always required a CAA for Crossbar.io), and because we pretty much agree with this blog https://www.arp242.net/license.html#european-union-public-license-12-eupl and it's conclusion

The EUPL seems to have all the same provisions as the AGPL, but with several advantages. I see no reason to prefer the AGPL over the EUPL;

oberstet commented 2 years ago

alright:

@om26er I have reverted your change https://github.com/crossbario/crossbar/commit/712d9da9173829be7df3ecba5dbb7981dd648fcd#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R45

this is wrong, and finding out did cost me a couple of hours:( but not your fault ultimately. python packaging is pretty fucked up. I want to move to Rust.