crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Shell always announces tls-unique #1992

Closed oberstet closed 2 years ago

oberstet commented 2 years ago

.. but it should only do on wss connections to the master node - currently it logs

crossbar shell show status

TLS transport channel_id for tls-unique requested, but _tlsConnection not found on transport ['SEND_LIMIT', 'TLS', '__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__implemented__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__providedBy__', '__provides__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_aborting', '_addressType', '_base', '_closeSocket', '_closeWriteConnection', '_collectSocketDetails', '_commonConnection', '_connectDone', '_dataReceived', '_finishInit', '_getLogPrefix', '_isSendBufferFull', '_maybePauseProducer', '_postLoseConnection', '_requiresResolution', '_setRealAddress', '_shouldShutdown', '_stopReadingAndWriting', '_tempDataBuffer', '_tempDataLen', '_tlsClientDefault', '_writeDisconnected', '_writeDisconnecting', 'abortConnection', 'addr', 'addressFamily', 'bufferSize', 'connected', 'connectionLost', 'connector', 'createInternetSocket', 'dataBuffer', 'disconnected', 'disconnecting', 'doConnect', 'doRead', 'doWrite', 'failIfNotConnected', 'fileno', 'getHandle', 'getHost', 'getPeer', 'getTcpKeepAlive', 'getTcpNoDelay', 'logPrefix', 'logstr', 'loseConnection', 'loseWriteConnection', 'offset', 'pauseProducing', 'producer', 'producerPaused', 'protocol', 'reactor', 'readConnectionLost', 'realAddress', 'registerProducer', 'resolveAddress', 'resumeProducing', 'setTcpKeepAlive', 'setTcpNoDelay', 'socket', 'socketType', 'startReading', 'startTLS', 'startWriting', 'stopConnecting', 'stopConsuming', 'stopProducing', 'stopReading', 'stopWriting', 'streamingProducer', 'unregisterProducer', 'write', 'writeConnectionLost', 'writeSequence', 'writeSomeData']
{
    "type": "domain", 
    "realm": "com.crossbario.fabric", 
    "now": "2022-04-11T12:41:17.958Z", 
    "started": "2022-04-11T12:32:20.867Z", 
    "uptime": "8 minutes", 
    "tick": 3
}

Finished command in 1.9 ms: crossbar shell show status

which stems from the following semi hackish code

https://github.com/crossbario/autobahn-python/blob/ceefbd87fe265e8a20f3770628e4face49f12e18/autobahn/twisted/util.py#L127

oberstet commented 2 years ago

fixed on 22.4.1:

(cpy39_1) (base) oberstet@intel-nuci7:~/scm/typedefint/crossbar-cluster$ crossbar shell show status

{
    "type": "domain", 
    "realm": "com.crossbario.fabric", 
    "now": "2022-05-05T23:17:54.406Z", 
    "started": "2022-05-05T21:51:49.690Z", 
    "uptime": "an hour", 
    "tick": 19
}

Finished command in 1.8 ms: crossbar shell show status