search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Database-backed cookie store: logout does not delete cookie #2025

Closed oberstet closed 2 years ago

oberstet commented 2 years ago

When using a database-backed cookie store, and with a client leaving a session with explicit logout (using reason=="wamp.close.logout"), the cookie must indeed be deleted - for more details and a problem demonstration, pls see https://github.com/crossbario/crossbar-examples/pull/156#issuecomment-1154528301

oberstet commented 2 years ago

relevant code starts here

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/router/session.py#L1204

and

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/router/session.py#L1213

and then depending on cookie store type, for memory-backed

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/router/cookiestore.py#L251

and for file and database backed

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/router/cookiestore.py#L345

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/router/cookiestore.py#L512