search

crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Forward CloseDetails.reason from proxy to router #2027

Closed oberstet closed 2 years ago

oberstet commented 2 years ago

We need to forward

Goodbye(message=some custom message that nobody uses and could be removed, reason=wamp.close.logout, resumable=None)

from here

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/worker/proxy.py#L244

to here

https://github.com/crossbario/crossbar/blob/6b6e25b1356b0641eff5dc5086d3971ecfb9a421/crossbar/worker/proxy.py#L1634

oberstet commented 2 years ago

alright, here is forwarding the close reason/message Bildschirmfoto von 2022-06-14 11-36-06

however, there is a yet missing 2nd part: delete the cookie - which needs to happen in the proxy worker, not in the router worker (to which we need to forward the close reason/message still so that it can kick other sessions)