crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 274 forks source link

Refactoring "identity_realm_name_category" to "identify_realm_name_category" #2059

Closed Skully17 closed 1 year ago

Skully17 commented 1 year ago

"identity_realm_name_category" was changed to "identify_realm_name_category" in autobahn: https://github.com/crossbario/autobahn-python/commit/8c57aff8f0d01b64b0e3fa32ddd5780cd43dd1bd

Bastian-Krause commented 1 year ago

This is a breaking change, so we need to bump the minimum autobahn version, right?

Bastian-Krause commented 1 year ago

Ah, seems to be already covered by #2060.

oberstet commented 1 year ago

@Bastian-Krause yeah, I am currently working to consolidate and test a new set of releases .. I am still working on crossbar, but autobahn-python and txaio should be good already (if nothing pops up from crossbar requiring another patch .. but I don't expect that)

oberstet commented 1 year ago

another release related note: both autobahn-python and txaio are now tested up to python 3.11 in various flavors https://github.com/crossbario/autobahn-python/actions/runs/3925457332

as said, I am still hashing out crossbar, but it will be compatible and tested on the same set fwiw, because of the amount of deps, and because python dep mgmt is seemi working, this is annoying and tricky, but I'm getting there ..

janrinze commented 1 year ago

just reinstalled crossbar using pip and the identity_realm_name_category error pops up.. Any chance this will get released ? Installing from github sources does not work for me.

work-around: replace the import manually with

from autobahn.wamp.message import identify_realm_name_category as identity_realm_name_category
oberstet commented 1 year ago

yeah, we should do a release .. and fact, I was on it, but got stopped by the upstream stuff mentioned here https://github.com/crossbario/autobahn-python/pull/1617 before a new autobahn release (which should come first, then crossbar ..). sorry

janrinze commented 1 year ago

Looks like it's not easy to keep both autobahn and crossbar in sync. Keep up the good work and hopefully we will see a new release soon.