crossbario / crossbar

Crossbar.io - WAMP application router
https://crossbar.io/
Other
2.05k stars 275 forks source link

Docker latest tag not updated? #2065

Closed gregerspoulsen closed 1 year ago

gregerspoulsen commented 1 year ago

The documentation recommends using the docker image from crossbario/crossbar (implicitly latest).

Currently the latest tag points to a 2 year old image, but there has been many releases of the source since then. Is this intentional?

oberstet commented 1 year ago

pls see https://hub.docker.com/r/crossbario/crossbar/tags?page=1&name=23.1.2

gregerspoulsen commented 1 year ago

Yes, I noticed a new version has been released on dockerhub, but the latest tag points to a release two years ago: https://hub.docker.com/r/crossbario/crossbar/tags?page=1&name=latest

I think it is generally accepted practice that the latest tag points to the most recent release, so I was a bit surprised when I noticed I was running a two year old release. If it's really intentional I think it should be mentioned somewhere in the documentation which specifically instructs to pull without specifying a tag.

Thanks for your time :)

gregerspoulsen commented 1 year ago

Btw. dockerhub has great integration with github for automatically publishing images. I would be happy to help here, but it isn't entirely clear to me how the release flow is around crossbar.

oberstet commented 1 year ago

I would be happy to help here, but it isn't entirely clear to me how the release flow is around crossbar.

oh, that would be very welcome! helping with build automation=)

there actually is another repo with docker files (and pyinstaller and snaps), which could be OSS'ed. this even includes arm64 etc

BUT: the actual time sucker is making sure those keep working at all. this project, due to amount and characteristics of deps and python building, and due to complexity, can be a black hole. you've been warned;)

if you are still willing to help, I could also give you access to https://github.com/typedefint/crossbar-binaries and you could have a look first and then you can see. it would be incredible welcome and helpful, but it is really a nerve wrecking time sucker;)

gregerspoulsen commented 1 year ago

I noticed you have workflows in this repo that installs crossbar and executes tests. Obviously when they break everything fails, but from the way you write I get the impression you have experienced many issues downstream even when they pass, can you elaborate on that?

oberstet commented 1 year ago

sure, just some notes that first pop to my mind. in general, the time spent with CI/CD issues of all kinds can be substantial. recently, I had this thought: I love Python (spent many years in c++ before), and I still do! But there are a couple of "issues" that really come and bite once a project has grown to the size/complexity of crossbar with Python. I really feel the price I paid cumulatively over the years on those - and I don't think they ever will disappear:( anyways, wining over.

Obviously when they break everything fails

yes indeed, this has gotten quite complex in itself. the reasons for failing in this first area are:

I get the impression you have experienced many issues downstream even when they pass, can you elaborate on that?