search

crossbeam-rs / rfcs

RFCs for changes to Crossbeam
Apache License 2.0
146 stars 13 forks source link

Introduce `Collector` API #15

Closed jeehoonkang closed 6 years ago

jeehoonkang commented 6 years ago

This is an RFC for introducing the Collector API.

Blocks https://github.com/crossbeam-rs/crossbeam-epoch/pull/21

Rendered

arthurprs commented 6 years ago

@jeehoonkang I see that you removed the line about perf. regression, is it solved?

jeehoonkang commented 6 years ago

@arthurprs Yes, I forgot to call Local::unregister(). After calling it, the performance regression is gone. That said, I have to admit that Local is not a user-friendly API: it's easy to forget to call unregister(), and forgetting to call unregister() may incur unbearable performance overhead.

jeehoonkang commented 6 years ago

Thank you for all the comments! This RFC is tightly coupled with the corresponding PR. Shall we merge them together? Or we'll have a review round for the PR?

ghost commented 6 years ago

Let's merge this RFC. 🎉🎉🎉