search

crosscloudci / cross-cloud

Cross-Cloud - multi-cloud K8s provisioner for CNCF CI Project
https://cncf.ci
Apache License 2.0
167 stars 59 forks source link

provider/vSphere: Make env destroy configurable #163

Closed akutz closed 6 years ago

akutz commented 6 years ago

This patch introduces the environment variable VSPHERE_DESTROY_SKIP. If set to true the deployed environment will not be deleted during the destroy step.

This PR fixes #162 and is related to #161; possibly #154.

akutz commented 6 years ago

Hi,

Would it be possible to identify any blockers to merging this PR? Thank you!

taylor commented 6 years ago

Thanks for changing the default to destroy. Re: https://github.com/crosscloudci/cross-cloud/issues/162#issuecomment-405401003

Please change the default to be destroy.

If an environment variable VSPHERE_DESTROY_SKIP is set to true then destroy will be skipped.

Ideally this can be applied to all providers. Then we can turn on skipping cleanup when we want to debug.

Summary:

Update code to skip destory if VSPHERE_DESTROY_SKIP == true Note: Default is destroy and environment var must be set