crosscloudci / cross-cloud

Cross-Cloud - multi-cloud K8s provisioner for CNCF CI Project
https://cncf.ci
Apache License 2.0
166 stars 59 forks source link

ATD-332 Change handling of OCI API private key for security purposes #179

Closed hbscharp closed 5 years ago

hbscharp commented 5 years ago

It was possible to glean the OCI API private key for the cncf-ci tenancy from the Gitlab log output. We revoked that key. This change removes the API key from the TF template handling and moves it to the provision script. They key should no longer be exposed now.

denverwilliams commented 5 years ago

Looks good, thanks! @hbscharp