search

crossdistro / network-testing

BSD 2-Clause "Simplified" License
6 stars 9 forks source link

some comments to html generator function #9

Closed jscotka closed 8 years ago

jscotka commented 8 years ago

https://github.com/pavlix/network-testing/blob/master/network_testing/client_server_genhtml.py#L58 FileNotFoundError is not defined in python2.7 (F23) it could be replaced by general Exception, or something similar what is in python2.7

using click library is nonsense, it is only "better option parser" but it only adds more dependencies (you have to install python-click, it is not in default intallation). So it should be replaced by general optparser instead of that.

using yaml adds another dependencies, I have to install pyyaml, but this is acceptable dependency, because of using yaml.

jscotka commented 8 years ago

Should be solved by https://github.com/pavlix/network-testing/pull/10

encukou commented 8 years ago

YAML can be replaced by JSON if the dependency is a problem.

jscotka commented 8 years ago

resolved by commit 93b681c into pavlix:master

jscotka commented 8 years ago

It is not big issue, but it adds dependency what is not installed by default. so that rpm have to install it to system too, although it can be replaced by json, what is there by default.