search

crossfilter / reductio

Reductio: Crossfilter grouping
Other
248 stars 42 forks source link

Accessor overwrite warnings no longer print if functions are identical #44

Closed XaserAcheron closed 8 years ago

XaserAcheron commented 8 years ago

Added an identity check before printing accessor overwrite warnings, since replacing a function with the exact same function is not really an overwrite. ;)

The short "why": I ran into a case where I couldn't easily switch to "boolean mode" when defining min, max, etc. since I'm constructing a reducer dynamically based on some other stuff. My attempts to circumvent the warnings got pretty ugly, and I figure an upstream PR wouldn't hurt.

While there, I also fixed a couple of items that seemed incorrect ('median' instead of 'min'/'max' in warning text and the wrong variable checked for exceptionCount). My apologies for not including them in a separate commit.

esjewett commented 8 years ago

Thanks for the pull request. At first glance this looks good, but I'm running a bit behind right now. I will try to check it more thoroughly, get it merged, and a patch release put out this weekend. If nothing happens and early next week rolls around, feel free to ping me :)

Thanks, Ethan

XaserAcheron commented 8 years ago

No rush, no worries. Thanks for taking a look n' things!

esjewett commented 8 years ago

This is now included in the 0.6.3 release. Thanks again for the contribution.