search

crosshare-org / crosshare

Crosshare is a free and ad-free community for crossword constructors and solvers
https://crosshare.org
GNU Affero General Public License v3.0
110 stars 28 forks source link

Fix enumeration warnings #508

Closed legnes closed 1 month ago

legnes commented 1 month ago

Seems like a couple of things might be wrong with the enumeration warnings:

In order to address the first problem, I tried to centralize the logic that decides what clues actually get included in the puzzle, so that the enumeration warnings can use it too. I think it will be useful in https://github.com/crosshare-org/crosshare/pull/507 as well, and it's possible it could be shared by the "missing clues" publishing error.

However, I'd totally understand if the priority is just to get the warnings fixed and not risk any modifications to the (rather critical) publishing code!

mdirolf commented 1 month ago

Looks great - thanks! I've added a basic test for some of these publish warnings which I'll push after merging this.