crosshare-org / crosshare

Crosshare is a free and ad-free community for crossword constructors and solvers
https://crosshare.org
GNU Affero General Public License v3.0
110 stars 28 forks source link

New Issues With Rebus Entry #520

Closed schmidzy closed 1 month ago

schmidzy commented 1 month ago

Hi Mike, noticing some odd rebus behavior today: the "More" button bounces back immediately to the main keyboard unless I long press, and then when I am able to press "Rebus," it also presses "V" on the main keyboard. Video attached. I'm using Chrome on Android 13. Thanks!

https://github.com/crosshare-org/crosshare/assets/165351060/ef8502b4-eab1-476a-a21a-e8d267f31013

mdirolf commented 1 month ago

Thanks for the heads up! Are the rest of the keys behaving as expected - the letter keys / backspace I mean?

mdirolf commented 1 month ago

It's almost certainly a result of these changes: https://github.com/crosshare-org/crosshare/commit/3f5eb91a64059548976e2ce113c9085a471af2a7 https://github.com/crosshare-org/crosshare/commit/5adcd1d25a1d0a99f88479ddaec2c639adfb2f1a

My guess is the onClick event isn't getting skipped because those buttons (more / rebus) disappear as soon as the onTouchStart is processed. Not sure why I'm not seeing this on other devices but should be easy enough to use the old logic for more/rebus

schmidzy commented 1 month ago

Sure thing! All the other keys are working normally for me; I just poked around with it some more and it seems the only ones affected are "More," "Rebus," and "ABC."

Cheers, Lydia

On Sun, May 19, 2024, 6:38 PM Mike Dirolf @.***> wrote:

Thanks for the heads up! Are the rest of the keys behaving as expected - the letter keys / backspace I mean?

— Reply to this email directly, view it on GitHub https://github.com/crosshare-org/crosshare/issues/520#issuecomment-2119381887, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHNQ5FF3Y3L65C5VWN7ASITZDESU3AVCNFSM6AAAAABH5X5Q4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGM4DCOBYG4 . You are receiving this because you authored the thread.Message ID: @.***>

mdirolf commented 1 month ago

This should be fixed - please give a shout if you have any more issues with it!