crossle / janus-gateway-android

Implements Janus gateway video room on Android
MIT License
60 stars 30 forks source link

How do we close the video room? #1

Closed antranvn closed 5 years ago

antranvn commented 5 years ago

Hello

crossle commented 5 years ago

Should close video from the MainActivity release

crossle commented 5 years ago

The NetworkMonitoAutoDetect in webrtc internal register, i saw your close code, it's should ok

lyapple2008 commented 5 years ago

I also found this error. Have you found the solution for this error?

lyapple2008 commented 5 years ago

I think we should close all PeerConnection in peerConnectionMap.

for (Map.Entry<BigInteger, JanusConnection> entry: peerConnectionMap.entrySet()) {
      if (entry.getValue().peerConnection != null) {
          entry.getValue().peerConnection.dispose();
      }
 }
antranvn commented 5 years ago

What webrtc version are you using now ?

lyapple2008 commented 5 years ago

This is not about the version of webrtc. You should close every peer connection when you save these peer connection in the variable, peerConnectionMap. in this example project. Otherwise, the PeerConnectionClient will not exist successfully.

crossle commented 5 years ago

@lyapple2008 Yes, should close all

antranvn commented 5 years ago

You are right @lyapple2008. Thank you both :)

akbarattar3 commented 4 years ago

Its still crashing with some exceptions when doing above code A/libc: Fatal signal 11 (SIGSEGV), code 2, fault addr 0x8af0d610 in tid 26834 (pool-1-thread-1) this is crash

pwjpj52 commented 2 years ago

you should alse disconnect websocet or you will not connect ice server