crossminer / scava

https://eclipse.org/scava/
Eclipse Public License 2.0
18 stars 13 forks source link

scava-overview dashboard : "last facts" vs "recommendations" #419

Closed mhow2 closed 4 years ago

mhow2 commented 4 years ago

Believing the screenshot, scava-overview dashboard filtered on project XWiki and sorted by date, it seems that "last facts" and "recommendations" are about the same ("recommendations" contains an additional project column).

image

Is there an explanation for it ? Isn't the term "recommendation" about the KB service ?

valeriocos commented 4 years ago

The recommendations table shows facts about the rascal metrics. If you open the visualization you can see the list of metrics: captura_125.

On the other hand, last facts shows the facts ordered by date.

mhow2 commented 4 years ago

The recommendations table shows facts about the rascal metrics

It seems the last facts show those too, that's the point. both viz look about the same

valeriocos commented 4 years ago

yes, because the "recommendations" are a subset of all facts. What do you suggest @mhow2 ?

mhow2 commented 4 years ago

@borisbaldassari : "recommendations" metrics is a subset of factoids metrics, eg rascal ones. "last facts" contains all metrics (that includes rascal ones).

It was the result of the work in https://github.com/crossminer/scava-deployment/issues/42 and especially https://github.com/crossminer/scava-deployment/issues/42#issuecomment-470488717

I'm trying to understand how "COCOMO" can turn into a recommendation (#421) and if we shouldn't rather leave it for the "last facts" table. I'm also wondering if we shouldn't simply remove all rascal metrics from "last facts" ? So we consolidate the spirit of have two tables for two separate purpose instead of mixing up.

WDYT ?

borisbaldassari commented 4 years ago

@mhow2 for the sake of visual consistency, it sounds good to have them separated and not showing up twice. m2c. :-) As for cocomo, you have to be warned that it's been debunked a couple of times and it may show really weird numbers..

valeriocos commented 4 years ago

Fixed with #426