Migrate to the 'typical' Functions CI

crossplane-contrib / function-cue-archived

Cuelang Integration for Crossplane's Composition Function

Apache License 2.0

10 stars 1 forks source link

Migrate to the 'typical' Functions CI #55

Closed negz closed 10 months ago

negz commented 12 months ago

What and Why?

Feel free to reject this PR if you prefer what's here already. This is propagating the Dockerfile and CI setup recently added to function-template-go. I've been updating all the functions to use it.

Fixes https://github.com/crossplane-contrib/function-cue/issues/47 [^1]

I have:

[ ] Read and followed the Contribution guide.
[ ] Added or updated unit tests for my change.

[^1]: I'll need to create a GitHub Actions secret so it can push to the Marketplace.

negz commented 12 months ago

@Mitsuwa If you still feel okay with this change I can fix up the linter errors that are blocking it.

Might make sense to wait for https://github.com/crossplane-contrib/function-cue/pull/51 to be merged first though.

Mitsuwa commented 12 months ago

sounds good to me, getting to the deprecated methods was also on my todo list so it would be good to update them

stevendborrelli commented 10 months ago

hello @Mitsuwa can you approve this PR if you are ok with the changes? There is some interest in this function from other users so it would be great to tag a release and push it to a registry.

Mitsuwa commented 10 months ago

@stevendborrelli i have made a copy of these changes on this pr https://github.com/crossplane-contrib/function-cue/pull/70 to fix the conflicts

Mitsuwa commented 10 months ago

I merged this in #70