crossplane-contrib / function-environment-configs

A function building the environment from EnvironmentConfigs
Apache License 2.0
15 stars 4 forks source link

environmentConfigs type enum #35

Open reedjosh opened 6 months ago

reedjosh commented 6 months ago

What happened?

...
type: selector
...

I didn't know the type should be capitalized. I spent a chunk of time trying to chase down the issue I was experiencing.

Turns out I should have capitalized Selector. 🙃

No rush, but for usability, doing some kind of input validation on what should be a binary enum would prevent the troubleshooting rabbithole I went down for a single char diff.

How can we reproduce it?

Be new to the function or just mistype the type of selector.

What environment did it happen in?

Function version: v0.0.7

phisco commented 6 months ago

Related to: https://github.com/crossplane/crossplane/issues/5094