search

crossplane-contrib / function-patch-and-transform

A patch & transform composition function
https://crossplane.io
Apache License 2.0
22 stars 24 forks source link

missing String transform Type "Join" #119

Closed haarchri closed 2 weeks ago

haarchri commented 3 months ago

we missing in p&t function String transform Type "Join" was implemented in crossplane via https://github.com/crossplane/crossplane/pull/5148

haarchri commented 3 months ago

think after implementation we need to update the converter in crossplane cli too

laseanb commented 3 months ago

If this is true - you have saved me a bunch of troubleshooting headache!! I just tried using the "Join" feature but I got the error:

cannot compose resources: pipeline step "patch-and-transform-queue-policy" returned a fatal result: cannot get Function input: cannot get Function input %!T(MISSING) from %!T(MISSING), into, req: cannot unmarshal JSON from *structpb.Struct into *v1beta1.Resources: json: cannot unmarshal Go value of type v1beta1.StringTransform: unknown name "join"
negz commented 3 months ago

What we really need to do is https://github.com/crossplane/crossplane/issues/4746 to eliminate this entire class of issues. 🙂

gschei commented 2 weeks ago

@haarchri this was implemented with #133 and release with v0.7.0, issue can be closed