crossplane-contrib / function-patch-and-transform

A patch & transform composition function
https://crossplane.io
Apache License 2.0
23 stars 24 forks source link

fix: Mark composite as unready if resources are skipped #137

Closed MisterMX closed 1 month ago

MisterMX commented 1 month ago

This small fix marks the desired composite as unready in the response if one of the resource templates is skipped due to a missing required patch path.

Related to https://github.com/crossplane-contrib/function-patch-and-transform/issues/12.

MisterMX commented 1 month ago

Closing since it does not actually solve the problem due to Crossplane ignoring the ready property for composite resources.

We solved this problem in a custom function implementation by keeping an arbitrary resource explicitly as unready until all other resources exist. Then the regular readiness checks takes over.