crossplane-contrib / function-patch-and-transform

A patch & transform composition function
https://crossplane.io
Apache License 2.0
26 stars 25 forks source link

Missing Environment-related Patch types shown in CRDs #48

Closed phisco closed 11 months ago

phisco commented 12 months ago

Patches defined at resources.patches are missing CombineToEnvironment,CombineFromEnvironment,ToEnvironmentFieldPath,FromEnvironmentFieldPathtypes in the generated CRD, this is not a blocker as we don't actually validate them, but it's still misleading and could become an issue if we start validating inputs from Crossplane.

We should update the relevant annotation, but probably also split Patches from EnvironmentPatches as we are doing in the upstream implementation, given that the latter support only a subset of types w.r.t. the former.