Patches defined at resources.patches are missing CombineToEnvironment,CombineFromEnvironment,ToEnvironmentFieldPath,FromEnvironmentFieldPathtypes in the generated CRD, this is not a blocker as we don't actually validate them, but it's still misleading and could become an issue if we start validating inputs from Crossplane.
We should update the relevant annotation, but probably also split Patches from EnvironmentPatches as we are doing in the upstream implementation, given that the latter support only a subset of types w.r.t. the former.
Patches defined at
resources.patches
are missingCombineToEnvironment,CombineFromEnvironment,ToEnvironmentFieldPath,FromEnvironmentFieldPath
types in the generated CRD, this is not a blocker as we don't actually validate them, but it's still misleading and could become an issue if we start validating inputs from Crossplane.We should update the relevant annotation, but probably also split Patches from EnvironmentPatches as we are doing in the upstream implementation, given that the latter support only a subset of types w.r.t. the former.