crossplane-contrib / provider-alibaba

Crossplane provider for Alibaba Cloud
Apache License 2.0
50 stars 18 forks source link

Return all available connection information on each RDS reconcile #19

Closed hasheddan closed 4 years ago

hasheddan commented 4 years ago

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Description of your changes

This updates the RDS controller to return any available connection details on each reconcile. Some are expected to only be available in Create or Observe, but using a consistent strategy for propagating makes reasoning about which values are being updated simpler and avoids having to specify connection details in each location.

Hopefully fixes https://github.com/crossplane/crossplane/issues/1575, but it needs to be additionally tested as I have not reproduced the behavior describe in that issue with the v0.1.0 release.

Opening for early review in case any folks more familiar with Alibaba may know what the underlying issue here may be.

Checklist

I have:

hasheddan commented 4 years ago

@hongchaodeng I meant to mark this as draft as it has not been tested manually yet, but I will make sure to test and follow up if additional changes are needed

hongchaodeng commented 4 years ago

sure. This is a low risk refactoring PR.