Implement OSS bucket management

crossplane-contrib / provider-alibaba

Crossplane provider for Alibaba Cloud

Apache License 2.0

50 stars 18 forks source link

Implement OSS bucket management #59

Closed zzxwill closed 3 years ago

zzxwill commented 3 years ago

Signed-off-by: Zheng Xi Zhou zzxwill@gmail.com

Description of your changes

Support provision and management of Alibaba Cloud OSS bucket resource.

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

zzxwill commented 3 years ago

@wonderflow @negz @lowkeyrd Please help review this PR:)

negz commented 3 years ago

Thanks @zzxwill! If someone from your team (or more generally someone familiar with the OSS API) can do a first pass review I'll find a Crossplane maintainer to take a look.

wonderflow commented 3 years ago

@negz Sure, we will review first round

negz commented 3 years ago

Apologies for the delayed response here - I dropped some comments on https://github.com/crossplane/provider-alibaba/pull/58 that at a glance seem like they will apply to this managed resource too. Let's align on that PR, then I will review this in more detail.

zzxwill commented 3 years ago

I ran make check-diff in my working client and my personal macOS, and both succeeded. So could the CI be triggered to have another shot? Thanks.